core: Add signal/timeout options to RunnableConfig #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handled by all built-in runnables - Handled by all utility methods in base runnable, which should propagate to basically all runnables
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
jacoblee93
reviewed
Aug 1, 2024
langchain-core/src/runnables/base.ts
Outdated
| this, | ||
| inputs, | ||
| optionsList, | ||
| runManagers, | ||
| batchOptions | ||
| ); | ||
| outputs = optionsList?.[0]?.signal |
jacoblee93
reviewed
Aug 1, 2024
jacoblee93
reviewed
Aug 1, 2024
langchain-core/src/runnables/base.ts
Outdated
| output = options?.signal | ||
| ? await Promise.race([ | ||
| promise, | ||
| new Promise<never>((_, reject) => { |
There was a problem hiding this comment.
Ah, edge case but what if someone passes an already aborted signal/there's some race condition?
Feel like there should be a check?
jacoblee93
reviewed
Aug 1, 2024
langchain-core/src/utils/signal.ts
Outdated
| if (signal === undefined) { | ||
| return promise; | ||
| } | ||
| if (signal.aborted) { |
There was a problem hiding this comment.
@nfcampos If we have this check here, do we need all the signal.throwIfAborted() calls elsewhere?
…nc/31jul/runnable-abort-signal
…nc/31jul/runnable-abort-signal
…to nc/31jul/runnable-abort-signal
dosubot
bot
added
size:XL
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)