core[minor]: Add status field to tool #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
dosubot
bot
added
size:M
jacoblee93
reviewed
Jul 30, 2024
| @@ -212,7 +212,8 @@ export abstract class StructuredTool< | |||
| let result; | |||
| try { | |||
| result = await this._call(parsed, runManager, config); | |||
| } catch (e) { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
Changes here seem fine but unrelated?
There was a problem hiding this comment.
forgot to remove when I deleted the error handling code from this PR.
|
Looks good! Only thing I'll flag is that streamed chunks will always have |
Going to push a refactor to leave undefined when concatenating unless it's passed. |
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new
statusfield to tools.TODO in separate PR:
statusfield.ToolNodeto usestatusfield.