Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs[patch]: Support hidden docs cells and TS validation in notebooks #6259

Merged
merged 1 commit into from
Jul 29, 2024
Merged

docs[patch]: Support hidden docs cells and TS validation in notebooks #6259

merged 1 commit into from
Jul 29, 2024

Conversation

jacoblee93
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:42pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:42pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jul 29, 2024
bracesproul
bracesproul approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks for doing this. Side question, roughly how much time does this add to the build process (just curious)

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 29, 2024
@jacoblee93
Copy link
Collaborator Author

It's just some extra fs operations so probably negligible and only for docs.

Will set something up to run the validate command on new notebooks only

@jacoblee93 jacoblee93 merged commit 9091012 into main Jul 29, 2024
29 checks passed
@jacoblee93 jacoblee93 deleted the jacob/notebooks branch July 29, 2024 21:42
@prathik2401 prathik2401 mentioned this pull request Aug 21, 2024
Merged
@riderx riderx mentioned this pull request Aug 21, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@renovate renovate bot mentioned this pull request Aug 23, 2024
Open
1 task
@riderx riderx mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoblee93 @bracesproul