anthropic[patch]: Proper handling of multi tool result messages #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bracesproul
commented
Jul 29, 2024
Comment on lines
161
to
182
| function _mergeAdjacentMessages( | ||
| messages: AnthropicMessageParam[] | ||
| ): AnthropicMessageParam[] { | ||
| return messages.reduce((acc: AnthropicMessageParam[], current, index) => { | ||
| if (index === 0) { | ||
| return [current]; | ||
| } | ||
|
|
||
| const previous = acc[acc.length - 1]; | ||
|
|
||
| if ( | ||
| previous.role === current.role && | ||
| Array.isArray(previous.content) && | ||
| Array.isArray(current.content) | ||
| ) { | ||
| previous.content = previous.content.concat(current.content); | ||
| return acc; | ||
| } | ||
|
|
||
| return [...acc, current]; | ||
| }, []); | ||
| } |
There was a problem hiding this comment.
cc @jacoblee93 this is the new util which fixes the bug
bracesproul
commented
Jul 29, 2024
| } | ||
| }); | ||
| return { | ||
| messages: _mergeAdjacentMessages(formattedMessages), |
There was a problem hiding this comment.
and @jacoblee93 it's called here
dosubot
bot
added
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: update merge adjacent util func to only merge tool_result types.