Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix mapStoredMessageToChatMessage to check on generic role when creating ChatMessage #6247

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: fix mapStoredMessageToChatMessage to check on generic role when creating ChatMessage #6247

merged 1 commit into from
Jul 29, 2024

Conversation

karlomedallo
Copy link
Contributor

  • Fixes mapStoredMessageToChatMessage to check on generic role when creating ChatMessage
  • Added test to ensure that when an instance of ChatMessage is converted to StoredMessage, it can be converted back.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 29, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:01am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 29, 2024 4:01am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 29, 2024
bracesproul
bracesproul approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 29, 2024
@bracesproul bracesproul merged commit f511afc into langchain-ai:main Jul 29, 2024
45 checks passed
@prathik2401 prathik2401 mentioned this pull request Aug 21, 2024
Merged
@riderx riderx mentioned this pull request Aug 21, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@riderx riderx mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlomedallo @bracesproul