Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build[patch]: Add way to escape side effects within an entrypoint #6174

Merged
merged 5 commits into from
Jul 23, 2024
Merged

build[patch]: Add way to escape side effects within an entrypoint #6174

merged 5 commits into from
Jul 23, 2024

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93 jacoblee93 commented Jul 23, 2024 •
edited
Loading

Also properly throw if a side effect is detected

@jacoblee93 jacoblee93 requested review from nfcampos and dqbd July 23, 2024 00:02
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:19am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 1:19am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 23, 2024
bracesproul
bracesproul approved these changes Jul 23, 2024
View reviewed changes
libs/langchain-scripts/src/build_v2.ts Show resolved Hide resolved
libs/langchain-scripts/src/build_v2.ts Outdated Show resolved Hide resolved
libs/langchain-scripts/src/build_v2.ts Outdated Show resolved Hide resolved
libs/langchain-scripts/src/build_v2.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 23, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 23, 2024
@jacoblee93 jacoblee93 merged commit 7dd7f6f into main Jul 23, 2024
30 checks passed
@jacoblee93 jacoblee93 deleted the jacob/escape_side_effects branch July 23, 2024 01:21
@prathik2401 prathik2401 mentioned this pull request Aug 15, 2024
Merged
@riderx riderx mentioned this pull request Aug 18, 2024
Open
@sam2177142 sam2177142 mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

@nfcampos nfcampos Awaiting requested review from nfcampos

@dqbd dqbd Awaiting requested review from dqbd

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoblee93 @bracesproul