Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[patch]: Typo fixed in Upstash Ratelimit Callback #6145

Conversation

Ibkdir
Copy link
Contributor

@Ibkdir Ibkdir commented Jul 19, 2024

In the Upstash Ratelimit Callback docs, limiter should be set to Ratelimit.fixedWindow(10, "60 s") instead of Ratelimit.fixedWindow(1, "60 s").

This is because the comment above it says "10 requests per window, where window size is 60 seconds:". The current docs have it as 1 request every 60 seconds

If you visit the Upstash docs, you see the correct syntax is as follows:

UpstashDocs

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:29am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 19, 2024 3:29am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jul 19, 2024
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 19, 2024
@bracesproul bracesproul changed the title community[patch]: Typo fixed in Upstash Ratelimit Callback docs[patch]: Typo fixed in Upstash Ratelimit Callback Jul 19, 2024
@bracesproul bracesproul merged commit 267dc5c into langchain-ai:main Jul 19, 2024
4 checks passed
@Ibkdir Ibkdir deleted the fixing_typo_in_upstash_ratelimit_callback branch July 19, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants