Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partners[minor]: Throw error if tool_choice is supplied but not supported #6119

Merged
merged 3 commits into from
Jul 17, 2024
Merged

partners[minor]: Throw error if tool_choice is supplied but not supported #6119

merged 3 commits into from
Jul 17, 2024

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Jul 17, 2024 •
edited
Loading

Throw an error if tool_choice is passed to a model which does not support it. Updated instances where call options interface extended BaseLanguageModelCallOptions instead of BaseChatModelCallOptions

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 11:01pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 11:01pm

@bracesproul bracesproul marked this pull request as ready for review July 17, 2024 22:24
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 17, 2024
@bracesproul bracesproul merged commit 639308d into main Jul 17, 2024
44 checks passed
@bracesproul bracesproul deleted the brace/throw-unsupported-tool-choice branch July 17, 2024 23:07
@prathik2401 prathik2401 mentioned this pull request Aug 15, 2024
Merged
@riderx riderx mentioned this pull request Aug 18, 2024
Open
@sam2177142 sam2177142 mentioned this pull request Aug 19, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Aug 21, 2024
Merged
@riderx riderx mentioned this pull request Aug 21, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@riderx riderx mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bracesproul