Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RefineChain #607

Merged
merged 13 commits into from
Apr 11, 2023
Merged

feat: Add RefineChain #607

merged 13 commits into from
Apr 11, 2023

Conversation

RohitMidha23
Copy link
Contributor

@RohitMidha23 RohitMidha23 commented Apr 4, 2023 •
edited
Loading

Added Refine Chain with prompts as present in the python library for QA.

For issue: #483

@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-docs ⬜️ Ignored (Inspect) Apr 11, 2023 8:37am

@RohitMidha23 RohitMidha23 changed the title feat: Add RefineChain fixes:https://github.com/hwchase17/langchainjs/issues/483 feat: Add RefineChain Apr 4, 2023
@RohitMidha23 RohitMidha23 changed the title feat: Add RefineChain feat: Add RefineChain #483 Apr 4, 2023
@RohitMidha23 RohitMidha23 changed the title feat: Add RefineChain #483 feat: Add RefineChain Apr 4, 2023
@nfcampos nfcampos linked an issue Apr 4, 2023 that may be closed by this pull request
Question: Will the Refine chain be implemented in langchainjs as well? #483
Closed
@vercel
Copy link

vercel bot commented Apr 4, 2023

@RohitMidha23 is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

hwchase17
hwchase17 reviewed Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! would be even better to have an example that we can plop in the documentation :)

one major comment around the existing_answer vairable

langchain/src/chains/question_answering/refine_prompts.ts Outdated Show resolved Hide resolved
langchain/src/chains/combine_docs_chain.ts Show resolved Hide resolved
@RohitMidha23
Copy link
Contributor Author

this is great! would be even better to have an example that we can plop in the documentation :)

one major comment around the existing_answer vairable

Will try to add an example but facing 429 issue when querying using OPENAI_API_KEY.

hwchase17
hwchase17 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! thanks

@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label Apr 11, 2023
@nfcampos nfcampos merged commit 38ed068 into langchain-ai:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 Awaiting requested review from hwchase17

Assignees
No one assigned
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Will the Refine chain be implemented in langchainjs as well?
3 participants
@RohitMidha23 @hwchase17 @nfcampos