Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[patch]: Bug fix for ParentDocumentRetriever #6061

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

clemenspeters
Copy link
Contributor

@clemenspeters clemenspeters commented Jul 15, 2024

Fix for bug introduced in #5989 (sorry about this).

Fixes error: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined

@PetersClemens

The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 15, 2024
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 9:38pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 15, 2024 9:38pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 15, 2024
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, other than that this fix lgtm

langchain/src/retrievers/parent_document.ts Outdated Show resolved Hide resolved
@bracesproul bracesproul changed the title Bug fix for ParentDocumentRetriever langchain[patch]: Bug fix for ParentDocumentRetriever Jul 15, 2024
Co-authored-by: Brace Sproul <braceasproul@gmail.com>
@jacoblee93
Copy link
Collaborator

Oof thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants