Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws[patch]: Fix empty content bug #6043

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Jul 11, 2024

Closes #5960

Fixes bug where messages with empty string contents were being passed to the Bedrock Converse API.

Added test for e2e use case, and test for the message converter util

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:38pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:38pm

@bracesproul bracesproul marked this pull request as ready for review July 11, 2024 20:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jul 11, 2024
@bracesproul bracesproul merged commit 6111718 into main Jul 11, 2024
30 checks passed
@bracesproul bracesproul deleted the brace/bedrock-empty-content-bug branch July 11, 2024 20:38
@tinque
Copy link
Contributor

tinque commented Jul 15, 2024

Hello @bracesproul,

Do you know when this should be released?

Thanks

@bracesproul
Copy link
Collaborator Author

@tinque Planning on releasing this today

@MarcoLooy
Copy link

@bracesproul super cool. Thanks a lot for fixing the issue, very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with ChatBedrockConverse and Bedrock Claude Model: ValidationException on Blank Text Field
3 participants