Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-genai[patch],openai[patch]: Test nits #6008

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

bracesproul
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 0:26am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 0:26am

@bracesproul bracesproul changed the title google-genai[patch]: Test nits google-genai[patch],openai[patch]: Test nits Jul 9, 2024
@bracesproul bracesproul marked this pull request as ready for review July 9, 2024 00:37
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 9, 2024
@bracesproul bracesproul merged commit 9acba0a into main Jul 9, 2024
45 checks passed
@bracesproul bracesproul deleted the brace/google-genai-test-nits branch July 9, 2024 00:37
@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Jul 9, 2024
@@ -1,3 +1,9 @@
import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the recent change in jest-setup-after-env.js adds code to access an environment variable using process.env. This comment is just to flag this change for your review. Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant