Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jacob/5890 #5956

Merged
merged 8 commits into from
Jul 2, 2024
Merged

jacob/5890 #5956

merged 8 commits into from
Jul 2, 2024

Conversation

jacoblee93
Copy link
Collaborator

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 2, 2024
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 1:16am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 1:16am

@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jul 2, 2024
@@ -0,0 +1,89 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 This PR includes changes to the peer and dev dependencies of the project, as well as an update to the minimum required Node.js version. I've flagged this for your review to ensure the changes align with the project's requirements. Keep up the great work! 🚀

@@ -0,0 +1,179 @@
import { getEnvironmentVariable } from "@langchain/core/utils/env";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the recent code changes explicitly add, access, read, or require an environment variable via process.env or getEnvironmentVariable. I've flagged this for the maintainers to review and ensure that the handling of environment variables aligns with best practices. Great work on the PR!

@@ -0,0 +1,198 @@
import { DocumentInterface } from "@langchain/core/documents";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and it looks great. I've left a comment flagging the use of environment variables for the maintainers to review. Keep up the good work!

@juliuslipp
Copy link
Contributor

@jacoblee93 Looks good to me! Please merge from here :)

@jacoblee93 jacoblee93 merged commit b35812c into main Jul 2, 2024
30 checks passed
@jacoblee93 jacoblee93 deleted the 5890 branch July 2, 2024 16:53
@jacoblee93
Copy link
Collaborator Author

Thank you! Live here: https://www.npmjs.com/package/@langchain/mixedbread-ai

@juliuslipp
Copy link
Contributor

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants