Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: support image url prompt with mustache #5916

Merged
merged 4 commits into from
Jun 28, 2024
Merged

core[patch]: support image url prompt with mustache #5916

merged 4 commits into from
Jun 28, 2024

Conversation

a1ooha
Copy link
Contributor

@a1ooha a1ooha commented Jun 27, 2024

Fix bug with image url prompt with mustache.

image

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 6:08pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 28, 2024 6:08pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jun 27, 2024
@bracesproul bracesproul changed the title fix: support image url prompt with mustache core[patch]: support image url prompt with mustache Jun 27, 2024
bracesproul
bracesproul approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jun 28, 2024
@bracesproul bracesproul merged commit 0079bf8 into langchain-ai:main Jun 28, 2024
3 checks passed
This was referenced Jul 24, 2024
Merged
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 1, 2024
Open
This was referenced Aug 2, 2024
Open
Open
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Aug 6, 2024
Merged
@steve-hb steve-hb mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 12, 2024
Closed
Closed
Closed
This was referenced Aug 12, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a1ooha @bracesproul