Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci[patch]: fix Unit Tests (LangChain Integrations) Skipping Test Jobs #5914

Merged
merged 19 commits into from
Jul 11, 2024
Merged

ci[patch]: fix Unit Tests (LangChain Integrations) Skipping Test Jobs #5914

merged 19 commits into from
Jul 11, 2024

Conversation

rameshkrishna
Copy link
Contributor

Unit Tests (LangChain Integrations) Workflow is Skipping Jobs due if condition failure.

Fixes Issue #5913

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 5:03pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 11, 2024 5:03pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jun 27, 2024
@rameshkrishna
Copy link
Contributor Author

CC @bracesproul @jacoblee93

bracesproul
bracesproul reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cab you push up some temp commits in an integration to verify this change works as expected?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
rameshkrishna
rameshkrishna commented Jun 28, 2024
View reviewed changes
libs/langchain-cloudflare/src/vectorstores.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp change to test workflow

bracesproul
bracesproul approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 11, 2024
@bracesproul bracesproul merged commit 281198d into langchain-ai:main Jul 11, 2024
26 checks passed
@rameshkrishna rameshkrishna mentioned this pull request Jul 13, 2024
Closed
5 tasks
@prathik2401 prathik2401 mentioned this pull request Jul 24, 2024
Merged
@prathik2401 prathik2401 mentioned this pull request Aug 6, 2024
Merged
@steve-hb steve-hb mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 12, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rameshkrishna @bracesproul