Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain-aws[major]: LangChain AWS package #5907

Merged
merged 18 commits into from
Jun 28, 2024
Merged

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Jun 26, 2024

todo:

  • docs
  • streamUsage constructor/call option field

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:31am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:31am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Jun 27, 2024
@@ -0,0 +1,65 @@
import { ChatBedrockConverse } from "@langchain/aws";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code and noticed that the recent changes explicitly access environment variables using process.env. I've flagged this for your review to ensure it aligns with our security and best practices. Let me know if you have any questions!

@@ -0,0 +1,42 @@
import * as fs from "node:fs/promises";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and noticed that the recent changes explicitly access environment variables via process.env. I've flagged this for your review to ensure it aligns with our best practices. Keep up the great work!

@@ -0,0 +1,55 @@
import { ChatBedrockConverse } from "@langchain/aws";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code and noticed that the addition explicitly accesses environment variables using process.env. I've flagged this for your review to ensure proper handling of environment variables. Let me know if you have any questions or need further assistance!

@@ -0,0 +1,31 @@
import { ChatBedrockConverse } from "@langchain/aws";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've noticed that the recent change in the PR explicitly accesses environment variables via process.env. I've flagged this for your review to ensure proper handling of sensitive information. Let me know if you need any further assistance with this!

@@ -0,0 +1,97 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the PR and noticed that there are changes to the project's dependencies, including additions to dev dependencies and a constraint on the TypeScript version. I've flagged this for your review as it may impact the project's functionality. Keep up the great work!

@@ -0,0 +1,442 @@
import type { BaseMessage } from "@langchain/core/messages";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code changes, and it looks like the diff adds and accesses environment variables using process.env and getEnvironmentVariable. I've flagged this for your review to ensure it aligns with the intended functionality. Let me know if you have any questions or need further assistance!

@@ -0,0 +1,307 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've flagged this PR for review because it introduces changes that access environment variables using process.env. Please ensure that the handling of environment variables aligns with our security and best practices. Thank you!

@@ -0,0 +1,61 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the recent code changes in the PR explicitly access environment variables using process.env. I've flagged this for your review to ensure that the handling of environment variables aligns with best practices. Let me know if you need any further assistance with this.

@@ -0,0 +1,41 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 This comment is to flag the addition of environment variables via process.env in the code changes for maintainers to review. It's important to ensure that the handling of environment variables is secure and follows best practices. Keep up the great work! 🚀

@bracesproul bracesproul merged commit f8c69c3 into main Jun 28, 2024
37 checks passed
@bracesproul bracesproul deleted the brace/langchain-aws branch June 28, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant