community[minor]: JinaAI embeddings integration #5842
Conversation
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:enhancement
![dosubot[bot]](https://github.com/avatars/in/324583?s=60&v=4){kind=small}
| @@ -0,0 +1,12 @@ | |||
| import { JinaEmbeddings } from "@langchain/community/embeddings/jina"; | |||
There was a problem hiding this comment.
Hey there! I've noticed that the recent code addition in jina.ts explicitly accesses an environment variable using process.env. I've flagged this for your review to ensure it aligns with our best practices for handling environment variables. Keep up the great work!
| @@ -0,0 +1,11 @@ | |||
| import { JinaEmbeddings } from "@langchain/community/embeddings/jina"; | |||
There was a problem hiding this comment.
Hey there! This PR adds a new HTTP request using the embedQuery method to retrieve embeddings from the Jina API. I've flagged this for your review to ensure it aligns with our API usage guidelines. Let me know if you have any questions or need further clarification!
| @@ -0,0 +1,11 @@ | |||
| import { JinaEmbeddings } from "@langchain/community/embeddings/jina"; | |||
There was a problem hiding this comment.
Hey there! I've flagged the recent change in the PR for maintainers to review, as it explicitly accesses an environment variable using process.env. This is an important security consideration, so it's good to double-check. Let me know if you need further assistance!
| @@ -0,0 +1,125 @@ | |||
| import { existsSync, readFileSync } from "fs"; | |||
There was a problem hiding this comment.
Hey there! I noticed that this PR introduces a new HTTP request using the fetch function to make a POST request to the JINA_API_URL endpoint. I've flagged this change for your review to ensure it aligns with the project's requirements. Let me know if you have any questions or need further clarification!
| @@ -0,0 +1,125 @@ | |||
| import { existsSync, readFileSync } from "fs"; | |||
There was a problem hiding this comment.
Great work on the PR! I've flagged this change for review by the maintainers as it involves accessing environment variables using the getEnvironmentVariable function. Keep up the good work!
|
Thank you! |
Description
Implemented a new embedding integration that makes JinaAI's embedding models available on langchainjs. A new class named JinaEmbeddings is created, which wraps the inference API.
This PR includes an example and integration tests related to the newly implemented class. Apart from the new integration's configuration, the original open-source components are intentionally left unchanged to avoid introducing any breaking changes.