Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs[minor]: bedrock tool calling/WSO docs #5735

Merged
merged 5 commits into from
Jun 23, 2024
Merged

docs[minor]: bedrock tool calling/WSO docs #5735

merged 5 commits into from
Jun 23, 2024

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Jun 11, 2024 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 1:17am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 1:17am

@bracesproul bracesproul marked this pull request as ready for review June 11, 2024 22:31
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:improvement Medium size change to existing code to handle new use-cases labels Jun 11, 2024
dosubot[bot]
dosubot bot reviewed Jun 11, 2024
View reviewed changes
examples/src/models/chat/integration_bedrock_tools.ts Outdated
@@ -0,0 +1,64 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that I've flagged a change in the PR for review. The added code explicitly accesses environment variables using process.env, so it's important to ensure that this is handled securely and appropriately. Let me know if you have any questions or need further clarification!

dosubot[bot]
dosubot bot reviewed Jun 11, 2024
View reviewed changes
examples/src/models/chat/integration_bedrock_wso.ts Outdated
@@ -0,0 +1,35 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code changes in this PR and flagged it for your review. The added code explicitly accesses environment variables using process.env, so it's important to ensure that this is handled securely and appropriately. Let me know if you have any questions or need further clarification!

dosubot[bot]
dosubot bot reviewed Jun 11, 2024
View reviewed changes
libs/langchain-community/src/chat_models/tests/chatbedrock.int.test.ts Outdated
@@ -383,3 +385,63 @@ test.skip.each([
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've flagged this PR for your review as it includes changes that access environment variables using process.env. Please take a look to ensure that the handling of environment variables aligns with our best practices.

@bracesproul bracesproul marked this pull request as draft June 11, 2024 23:53
@bracesproul bracesproul marked this pull request as ready for review June 22, 2024 01:08
dosubot[bot]
dosubot bot reviewed Jun 22, 2024
View reviewed changes
examples/src/models/chat/integration_bedrock_tools.ts
@@ -0,0 +1,63 @@
import { BedrockChat } from "@langchain/community/chat_models/bedrock";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and flagged a specific change related to accessing environment variables using process.env. This is to ensure the maintainers review and confirm the handling of environment variables in the code. Let me know if you need further assistance!

dosubot[bot]
dosubot bot reviewed Jun 22, 2024
View reviewed changes
examples/src/models/chat/integration_bedrock_wso.ts
@@ -0,0 +1,34 @@
import { BedrockChat } from "@langchain/community/chat_models/bedrock";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code changes and noticed that environment variables are being accessed using process.env. I've flagged this for your review to ensure that the handling of environment variables aligns with best practices. Let me know if you have any questions!

@bracesproul bracesproul changed the title community[minor]: Add withStructuredOutput to bedrock docs[minor]: bedrock tool calling/WSO docs Jun 22, 2024
@bracesproul bracesproul merged commit ff0ac6e into main Jun 23, 2024
20 checks passed
@bracesproul bracesproul deleted the brace/bedrock-with-structured-output branch June 23, 2024 22:11
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 4, 2024
Open
@gmickel gmickel mentioned this pull request Jul 17, 2024
Open
@gmickel gmickel mentioned this pull request Jul 19, 2024
Open
@Skrishnan586 Skrishnan586 mentioned this pull request Jul 22, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Jul 24, 2024
Merged
@renovate renovate bot mentioned this pull request Jul 26, 2024
Open
1 task
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot DosuBot dosubot left review comments

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bracesproul