community[patch]: ElasticVectorSearch - fix error when no bulk operations #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
jacoblee93
changed the title
|
Makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in discussion # (discussion)
Description is in the attached issue/discussion. Basically, it was observed on
incrementalcleanup when calling theindex(...)function a crash when trying to delete an empty list of elements. The deletion in Elastic is done by aPOST _bulkrequest, which expects a non-emtpy list of operations. When there is no elements to delete, the list of operations is empty, hence the error. Easy to replicate straight in the Elastic Console (i.e. http://localhost:5601/app/dev_tools#/console) by writing justPOST _bulk.