community[minor]: Basic Fireworks function calling notebook + embeddings code #4447
Conversation
benjibc
commented
Feb 17, 2024
•
benjibc
commented
- Basic Dino notebook with LangChain tools and Fireworks function calling model
- Code for Fireworks Embeddings
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:documentation
![dosubot[bot]](https://github.com/avatars/in/324583?s=60&v=4){kind=small}
| @@ -0,0 +1,152 @@ | |||
| import { getEnvironmentVariable } from "@langchain/core/utils/env"; | |||
There was a problem hiding this comment.
Hey there! I noticed that the recent changes added a new HTTP request using fetch to the Fireworks AI API in the embeddingWithRetry method. I've flagged this for your review to ensure it aligns with the project's requirements. Let me know if you have any questions or need further clarification.
| @@ -0,0 +1,152 @@ | |||
| import { getEnvironmentVariable } from "@langchain/core/utils/env"; | |||
There was a problem hiding this comment.
Hey there! 👋 I've reviewed the code changes, and it looks like the addition of environment variable access via getEnvironmentVariable is flagged for review. This is important for maintainers to ensure proper handling of sensitive information. Great work, and let me know if you have any questions!
benjibc
force-pushed
the
basic_langchain_fw_fc_and_embeddings
branch
from
ab8f5c6
to
c4cec08
Compare
jacoblee93
changed the title
|
Code looks good! I can't view the notebook in the diff, but will try locally later today. We'll want to add a page under the integrations docs as well, but I can do that later as well. Thanks for your patience! |
…basic_langchain_fw_fc_and_embeddings
|
@jacoblee93 I think this link works: https://github.com/langchain-ai/langchainjs/blob/c4cec0877411f2b3bf6270e67be4e02fa6e54f9d/cookbook/function_calling_fireworks.ipynb . For where to add the docs, perfectly happy to do the work, is this the doc you have in mind? https://github.com/langchain-ai/langchainjs/tree/main/libs/langchain-community ? If not can you provide me some pointers? |
|
Thank you! |
