Fix WhatsAppChatLoader : Enable parsing additional formats #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augtheo
commented
Jun 23, 2023
augtheo
commented
- Description: Updated regex to support a new format that was observed when whatsapp chat was exported.
- Issue: WhatsAppChatLoader doesn't extract messages exported from WhatsApp #6654
- Dependencies: No new dependencies
- Tag maintainer: @rlancemartin, @eyurtsev
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dev2049
reviewed
Jun 23, 2023
There was a problem hiding this comment.
while we're here, could we move this to test/unit_tests instead of integration tests?
There was a problem hiding this comment.
Hello @dev2049
Regarding your suggestion to move this to test/unit_tests instead of integration tests, should we relocate just this specific test or all the document_loader tests to test/unit_tests?
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.