Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _similarity_search_with_relevance_scores in Pinecone #6446

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add _similarity_search_with_relevance_scores in Pinecone #6446

merged 1 commit into from
Jun 20, 2023

Conversation

neo
Copy link
Contributor

@neo neo commented Jun 19, 2023

Just so it is consistent with other VectorStore classes.

This is a follow-up of #6056 which also discussed the potential of adding similarity_search_by_vector_returning_embeddings that we will continue the discussion here.

potentially related: #6286

Who can review?

Tag maintainers/contributors who might be interested: @rlancemartin

to be consistent with other `VectorStore` classes
@vercel
Copy link

vercel bot commented Jun 19, 2023

@neo is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit 76ae9da into langchain-ai:master Jun 20, 2023
@neo
Copy link
Contributor Author

neo commented Jun 20, 2023

There was discussion with @rlancemartin about whether to add similarity_search_by_vector_returning_embeddings that first appeared in the supabase vector store, not sure we want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants