Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for structured tools #5989

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Conversation

hwchase17
Copy link
Contributor

No description provided.

@hwchase17 hwchase17 requested a review from eyurtsev June 10, 2023 18:49
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@eyurtsev
Copy link
Collaborator

This looks good, I started working on separate code will try to push on Monday to populate required field which is useful to have.

I think we also need to expose another parameter in the function classmethod to allow a user to provide per argument doc-strings

@hwchase17 hwchase17 merged commit ca1afa7 into master Jun 10, 2023
@hwchase17 hwchase17 deleted the harrison/structured-tools-test branch June 10, 2023 21:37
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants