Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openai proxy error #5914

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Fix openai proxy error #5914

merged 2 commits into from
Jun 9, 2023

Conversation

Fei-Wang
Copy link
Contributor

@Fei-Wang Fei-Wang commented Jun 9, 2023

Fixes proxy error.
Since openai does not parse proxy parameters and uses openai.proxy directly, the proxy method needs to be modified.

https://github.com/openai/openai-python/blob/7610c5adfaebe3ffdb9927a551a741a3fab1b62e/openai/api_requestor.py#LL90

Who can review?

@hwchase17 - project lead

Models

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for flaggin!

@hwchase17 hwchase17 merged commit 63fcf41 into langchain-ai:master Jun 9, 2023
@Fei-Wang Fei-Wang deleted the fix_openai_proxy branch June 9, 2023 06:16
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
Fixes proxy error.
Since openai does not parse proxy parameters and uses openai.proxy
directly, the proxy method needs to be modified.


https://github.com/openai/openai-python/blob/7610c5adfaebe3ffdb9927a551a741a3fab1b62e/openai/api_requestor.py#LL90

#### Who can review?
  @hwchase17 - project lead

  Models
  - @hwchase17
  - @agola11

---------

Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants