Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qdrant vector store - search with relevancy scores #5781

Conversation

bnassivet
Copy link
Contributor

Implementation of similarity_search_with_relevance_scores for quadrant vector store.
As implemented the method is also compatible with other capacities such as filtering.

Integration tests updated.

Who can review?

Tag maintainers/contributors who might be interested:

VectorStores / Retrievers / Memory

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 6, 2023
@bnassivet
Copy link
Contributor Author

fixed a formatting issue

@hwchase17 hwchase17 merged commit 9355e3f into langchain-ai:master Jun 8, 2023
@kacperlukawski
Copy link
Contributor

That will only work if we use cosine distance. However, there is no upper limit if we use dot product or Euclidean distance. @hwchase17 What should be the behavior in such a case?

Moreover, Qdrant supports limiting the results by score on the server-side, which will be implemented soon, similar to #4858.

Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
Implementation of similarity_search_with_relevance_scores for quadrant
vector store.
As implemented the method is also compatible with other capacities such
as filtering.

Integration tests updated.


#### Who can review?

Tag maintainers/contributors who might be interested:

  VectorStores / Retrievers / Memory
  - @dev2049
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants