Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes (linting and broken links) #5563

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

sseide
Copy link
Contributor

@sseide sseide commented Jun 1, 2023

Lint sphinx documentation and fix broken links

This PR lints multiple warnings shown in generation of the project documentation (using "make docs_linkcheck" and "make docs_build"). Additionally documentation internal links to (now?) non-existent files are modified to point to existing documents as it seemed the new correct target.

The documentation is not updated content wise.
There are no source code changes.

Fixes # (issue)

  • broken documentation links to other files within the project
  • sphinx formatting (linting)

Before submitting

No source code changes, so no new tests added.

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:

@dev2049 dev2049 added the documentation Improvements or additions to documentation label Jun 1, 2023
@dev2049
Copy link
Contributor

dev2049 commented Jun 1, 2023

this is awesome, thank you @sseide!

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 1, 2023
@dev2049 dev2049 merged commit 001b147 into langchain-ai:master Jun 1, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
@sseide sseide deleted the documentation-fixes branch June 9, 2023 09:14
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Lint sphinx documentation and fix broken links

This PR lints multiple warnings shown in generation of the project
documentation (using "make docs_linkcheck" and "make docs_build").
Additionally documentation internal links to (now?) non-existent files
are modified to point to existing documents as it seemed the new correct
target.

The documentation is not updated content wise.
There are no source code changes.

Fixes # (issue)

- broken documentation links to other files within the project
- sphinx formatting (linting)

## Before submitting

No source code changes, so no new tests added.

---------

Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants