Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the elasticsearch api support version which below 8.x #5495

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

ARSblithe212
Copy link
Contributor

Your PR Title (What it does)

make the elasticsearch api support version which below 8.x

@hwchase17

@dev2049

-->

@dev2049
Copy link
Contributor

dev2049 commented May 31, 2023

cc @jeffvestal

@jeffvestal
Copy link
Contributor

LGTM
It'll add a tiny bit of response latency having to do a version check for every search query, but in the overall time of script score vector search I doubt it will matter or even be noticeable.

@dev2049 dev2049 merged commit 80b3fdf into langchain-ai:master Jun 1, 2023
@dev2049
Copy link
Contributor

dev2049 commented Jun 1, 2023

thanks @ARSblithe212!

@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
…-ai#5495)

the api which create index or search in the elasticsearch below 8.x is
different with 8.x. When use the es which below 8.x , it will throw
error. I fix the problem


Co-authored-by: gaofeng27692 <gaofeng27692@hundsun.com>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants