Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedrock llm and embeddings #5464

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

3coins
Copy link
Contributor

@3coins 3coins commented May 30, 2023

Bedrock LLM and Embeddings

This PR adds a new LLM and an Embeddings class for the Bedrock service. The PR also includes example notebooks for using the LLM class in a conversation chain and embeddings usage in creating an embedding for a query and document.

Note: AWS is doing a private release of the Bedrock service on 05/31/2023; users need to request access and added to an allowlist in order to start using the Bedrock models and embeddings. Please use the Bedrock Home Page to request access and to learn more about the models available in Bedrock.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty clean and straightforward to me! still marked as draft, so assuming its awaiting something more?

@jasondotparse
Copy link
Contributor

looks pretty clean and straightforward to me! still marked as draft, so assuming its awaiting something more?

Still adding a few more notes, and ensuring all parties have had a chance to add theirs as well :)

@3coins
Copy link
Contributor Author

3coins commented May 30, 2023

@hwchase17
Thanks for responding so quickly to the PR. I will move it out of draft shortly, once some internal folks have reviewed.

@dev2049 dev2049 added 03 enhancement Enhancement of existing functionality llms Ɑ: embeddings Related to text embedding models module labels May 30, 2023
@3coins 3coins changed the title Added bedrock llm and embeddings Bedrock llm and embeddings May 30, 2023
@3coins 3coins marked this pull request as ready for review May 31, 2023 00:37
@ellisonbg
Copy link

Looks good to me! As folks try this out, please let us (myself, @3coins, @jasondotparse) know if you run into issues by opening issues on this repo and @ mentioning us.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@hwchase17 hwchase17 merged commit 562fdfc into langchain-ai:master May 31, 2023
vowelparrot pushed a commit that referenced this pull request May 31, 2023
# Bedrock LLM and Embeddings
This PR adds a new LLM and an Embeddings class for the
[Bedrock](https://aws.amazon.com/bedrock) service. The PR also includes
example notebooks for using the LLM class in a conversation chain and
embeddings usage in creating an embedding for a query and document.

**Note**: AWS is doing a private release of the Bedrock service on
05/31/2023; users need to request access and added to an allowlist in
order to start using the Bedrock models and embeddings. Please use the
[Bedrock Home Page](https://aws.amazon.com/bedrock) to request access
and to learn more about the models available in Bedrock.

<!-- For a quicker response, figure out the right person to tag with @

  @hwchase17 - project lead

  Tracing / Callbacks
  - @agola11

  Async
  - @agola11

  DataLoaders
  - @eyurtsev

  Models
  - @hwchase17
  - @agola11

  Agents / Tools / Toolkits
  - @vowelparrot

  VectorStores / Retrievers / Memory
  - @dev2049

 -->
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Bedrock LLM and Embeddings
This PR adds a new LLM and an Embeddings class for the
[Bedrock](https://aws.amazon.com/bedrock) service. The PR also includes
example notebooks for using the LLM class in a conversation chain and
embeddings usage in creating an embedding for a query and document.

**Note**: AWS is doing a private release of the Bedrock service on
05/31/2023; users need to request access and added to an allowlist in
order to start using the Bedrock models and embeddings. Please use the
[Bedrock Home Page](https://aws.amazon.com/bedrock) to request access
and to learn more about the models available in Bedrock.

<!-- For a quicker response, figure out the right person to tag with @

  @hwchase17 - project lead

  Tracing / Callbacks
  - @agola11

  Async
  - @agola11

  DataLoaders
  - @eyurtsev

  Models
  - @hwchase17
  - @agola11

  Agents / Tools / Toolkits
  - @vowelparrot

  VectorStores / Retrievers / Memory
  - @dev2049

 -->
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 enhancement Enhancement of existing functionality Ɑ: embeddings Related to text embedding models module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants