Fixes iter error in FAISS add_embeddings call #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atempted re-use of iter within add_embeddings resulted in error /refs langchain-ai#5336
14 tasks
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
# Remove re-use of iter within add_embeddings causing error As reported in langchain-ai#5336 there is an issue currently involving the atempted re-use of an iterator within the FAISS vectorstore adapter Fixes # langchain-ai#5336 ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: VectorStores / Retrievers / Memory - @dev2049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove re-use of iter within add_embeddings causing error
As reported in #5336 there is an issue currently involving the atempted re-use of an iterator within the FAISS vectorstore adapter
Fixes # #5336
Who can review?
Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
VectorStores / Retrievers / Memory