Add html parsers #4874
Merged
Add html parsers #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev2049
approved these changes
May 17, 2023
| def __init__( | ||
| self, | ||
| features: str = "lxml", | ||
| bs_kwargs: Optional[Mapping[str, Any]] = None, |
There was a problem hiding this comment.
ooc (out of curiosity) how do you think about passing in kwargs as dict vs **kwargs?
There was a problem hiding this comment.
why not :)
My main concern tends to be that there might be another function that'll require them... but here maybe it's OK to assume it goes into the initializer by default, and everything else has to be explicitly specified
dev2049
reviewed
May 17, 2023
|
|
||
| def __init__( | ||
| self, | ||
| features: str = "lxml", |
There was a problem hiding this comment.
should we add this to bs4html loader as well?
There was a problem hiding this comment.
it's already there, just hidden in the init
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bs4 html parser