-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add Objective vector search #24214
Open
hbmartin
wants to merge
9
commits into
langchain-ai:master
Choose a base branch
from
hbmartin:add-objective-community
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+582
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b878718
to
2188dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Related to langchain-community
🤖:enhancement
A large net-new component, integration, or chain. Use sparingly. The largest features
size:XL
This PR changes 500-999 lines, ignoring generated files.
Ɑ: vector store
Related to vector store module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds an implantation for Objective subclassing
VectorStore
to community.vectorstores.objectiveIssue: none
Dependencies: none
Twitter handle: hmartin
Tests: I'm unsure what I can do here since every call depends on network access and also I'm not affiliated with Objective so I can't provide demo keys. If this is huge blocker I could try to reach out?
Doc / notebook: langchain/docs/docs/integrations/vectorstores/objective.ipynb
NOTE: This PR modifies
docs/scripts/check_templates.py
to produce header specific errors to explain to the user why it failed. Happy to move this to a separate PR if desired.If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.