Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: replace it with Tencent Cloud SDK #24172

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

yanchunan
Copy link
Contributor

Description: The old method will be discontinued; use the official SDK for more model options.
Issue: None
Dependencies: None
Twitter handle: None

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 11:53pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 12, 2024
@yanchunan
Copy link
Contributor Author

Hi @eyurtsev I'm sorry to bother you, but how can I merge this PR?

@eyurtsev
Copy link
Collaborator

@yanchunan could you share the a URL to the relevant API documentation

@eyurtsev eyurtsev self-assigned this Jul 25, 2024
@yanchunan
Copy link
Contributor Author

yanchunan commented Jul 26, 2024

@yanchunan could you share the a URL to the relevant API documentation

@eyurtsev Currently, only Chinese documentation is provided.
The API documentation is https://cloud.tencent.com/document/product/1729/105701,
and the SDK is https://github.com/TencentCloud/tencentcloud-sdk-python/tree/master/tencentcloud/hunyuan

@wxg0103
Copy link

wxg0103 commented Jul 26, 2024

Your submission will be of great help to me. I hope it can be merged as soon as possible. Of course, if you can provide a complete example, I will be very grateful.

@wxg0103
Copy link

wxg0103 commented Jul 26, 2024

By the way, is there no embedding that supports the hunyuan model?

@yanchunan
Copy link
Contributor Author

By the way, is there no embedding that supports the hunyuan model?

It hasn't been provided yet, but more features will be added gradually in the future.

@wxg0103
Copy link

wxg0103 commented Jul 29, 2024

@baskaryan, @efriis, @eyurtsev, @ccurme, @vbarda, @hwchase17 Could you guys help me to review this PR?
Thanks

Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm that you've run the integration tests and they pass? (Langchain CI does not run integration tests for community integrations.)

Does the documentation here need to be updated at all? Notebook is here: https://github.com/langchain-ai/langchain/blob/master/docs/docs/integrations/chat/tencent_hunyuan.ipynb

@yanchunan
Copy link
Contributor Author

integration
@ccurme
Yes, all the integration tests have passed.
image
This update is compatible with older versions, so the documentation does not need to be updated.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 31, 2024
@ccurme ccurme merged commit 096b66d into langchain-ai:master Jul 31, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants