Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qdrant: Documentation for the new QdrantVectorStore class #24166

Merged
merged 14 commits into from
Jul 15, 2024
Merged

qdrant: Documentation for the new QdrantVectorStore class #24166

merged 14 commits into from
Jul 15, 2024

Conversation

Anush008
Copy link
Contributor

Description

Follow up on #24165. Adds a page to document the latest usage of the new QdrantVectorStore class.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 5:13pm

@dosubot dosubot bot added 🔌: qdrant Primarily related to Qdrant vector store integration 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jul 12, 2024
@Anush008 Anush008 mentioned this pull request Jul 12, 2024
Merged
efriis
efriis reviewed Jul 12, 2024
View reviewed changes
docs/docs/how_to/hybrid.ipynb Outdated Show resolved Hide resolved
docs/docs/integrations/platforms/index.mdx Outdated Show resolved Hide resolved
docs/docs/integrations/platforms/index.mdx Outdated Show resolved Hide resolved
docs/docs/integrations/vectorstores/qdrant-new.ipynb Outdated Show resolved Hide resolved
efriis pushed a commit that referenced this pull request Jul 12, 2024
@Anush008
qdrant: Bump patch version (#24168)
d09dda5 
# Description

To release a new version of `langchain-qdrant` after #24165 and #24166.
@Anush008 Anush008 requested a review from efriis July 13, 2024 06:31
@efriis efriis self-assigned this Jul 15, 2024
efriis
efriis reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! I think my comment wasn't clear. Let's delete qdrant-new.ipynb and merge any relevant contents into qdrant.ipynb! If the old one is deprecated/not recommended for new users, let's either delete those sections of qdrant.ipynb, or put them at the bottom with a note that you recommend using the new implementation instead.

As we've discussed before, having these two separate implementations is going to be confusing for users, so some notes about why someone might use one vs the other would be appreciated as well!

@efriis efriis marked this pull request as draft July 15, 2024 16:42
@Anush008 Anush008 marked this pull request as ready for review July 15, 2024 16:55
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 15, 2024
@Anush008
Copy link
Contributor Author

Anush008 commented Jul 15, 2024 •
edited
Loading

Hey @efriis. I've updated the changes into qdrant.ipynb and deleted the new page.

The page documents only the new usage pattern.

efriis
efriis approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 15, 2024
@efriis efriis merged commit d93ae75 into langchain-ai:master Jul 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: qdrant Primarily related to Qdrant vector store integration size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anush008 @efriis