Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Del schema #24162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Del schema #24162

wants to merge 1 commit into from

Conversation

hinthornw
Copy link
Collaborator

i really want this

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 12, 2024
Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 12, 2024 0:47am

@dosubot dosubot bot added the Ɑ: core Related to langchain-core label Jul 12, 2024
@@ -290,7 +290,7 @@ def create_schema_from_function(
# Pydantic adds placeholder virtual fields we need to strip
valid_properties = _get_filtered_args(inferred_model, func, filter_args=filter_args)
return _create_subset_model(
f"{model_name}Schema",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to take into account the users that might rely on this name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants