-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain: default to langsmith sdk for pulling prompts, fallback to langchainhub #24156
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -33,7 +36,7 @@ def push( | |||
api_url: Optional[str] = None, | |||
api_key: Optional[str] = None, | |||
parent_commit_hash: Optional[str] = "latest", | |||
new_repo_is_public: bool = True, | |||
new_repo_is_public: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible to make these Optional[bool] = None
and have the defaults encoded in sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
Description: Deprecating langchainhub, replacing with langsmith sdk