openai: raw response headers #24150
Merged
openai: raw response headers #24150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:XS
efriis
changed the title
dosubot
bot
added
🔌: openai
efriis
commented
Jul 15, 2024
| @@ -510,7 +512,9 @@ def _stream( | |||
| kwargs["stream"] = True | |||
| payload = self._get_request_payload(messages, stop=stop, **kwargs) | |||
| default_chunk_class: Type[BaseMessageChunk] = AIMessageChunk | |||
| with self.client.create(**payload) as response: | |||
| with self.client.with_raw_response.create(**payload) as raw_response: | |||
There was a problem hiding this comment.
tradeoff: this code is more maintainable, but it won't tolerate custom client/async_client that doesn't implement with_raw_response (i.e. non-openai clients)
Could make it tolerate this by only raw-responsing if include_response_headers is set to true.
I'm generally in favor of maintainability here. Happy to discuss.
There was a problem hiding this comment.
switching back to not break things
efriis
commented
Jul 15, 2024
There was a problem hiding this comment.
these were just copypasta from openai but rely on openai package internals. delete.
dosubot
bot
added
size:L
efriis
changed the title
baskaryan
approved these changes
Jul 16, 2024
dosubot
bot
added
the
lgtm
ccurme
added a commit
that referenced
this pull request
Jul 17, 2024
Fixes small issues introduced in #24150 (unreleased).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.