core[minor],langchain[minor]: RFC test out indexing abstraction #24145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eyurtsev
added
the
08 RFC
eyurtsev
commented
Jul 12, 2024
| # filtering syntax. | ||
| # The syntax is as follows: | ||
| # - All operators and comparators should be prefixed with a "$". | ||
| # - Field names are expected to be valid identifiers allowing [a-zA-Z0-9_] |
There was a problem hiding this comment.
TBD nested fields
eyurtsev
commented
Jul 12, 2024
| filter: Union[Dict[str, Any], List[Dict[str, Any]]], | ||
| /, | ||
| **kwargs: Any, | ||
| ) -> Iterable[DeleteResponse]: |
There was a problem hiding this comment.
IMO We should probably make this method just return a delete response, and stop worrying about including the ids of deleted content in the delete response as part of this interface. Those IDs aren't that useful and take extra effort to get. It'll also mean that folks don't have to iterate through delete by filter to use it.
| """ | ||
|
|
||
| @abc.abstractmethod | ||
| def delete_by_ids( |
There was a problem hiding this comment.
Potentially merge with delete to avoid introducing another method.
We'd need to update the response type here to just be a bool. We likely don't need counts or IDs anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test out indexing abstraction on parent retriever