Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Update typing for template format to include jinja2 as a Literal #24144

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

tibor-reiss
Copy link
Contributor

Fixes #23929 via adjusting the typing

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 8:12pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jul 11, 2024
@eyurtsev eyurtsev self-assigned this Jul 12, 2024
@eyurtsev eyurtsev self-requested a review July 16, 2024 13:09
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 16, 2024
@eyurtsev eyurtsev changed the title core: fix for typing core[patch]: Update typing for template format to include jinja2 as a Literal Jul 16, 2024
@eyurtsev eyurtsev merged commit 1c753d1 into langchain-ai:master Jul 16, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class ChatPromptTemplate > def from_messages > template_format bug
2 participants