-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: retrievers: added capability for using Product Quantization as one of the retriever. #22424
community: retrievers: added capability for using Product Quantization as one of the retriever. #22424
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a docs page to docs/docs/integrations/retrievers/?
return np.array(list(executor.map(embeddings.embed_query, contexts))) | ||
|
||
|
||
class PQRetriever(BaseRetriever): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we call this something like NanoPQRetriever to make clear what dependency is being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Felt like the algorithm's name should be given more importance than the package. Thought similar on the lines of TF-IDF, SVM or KNN. However, let me if package based naming would make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think since this package is less well known/used than sklearn its more important to make it obvious whats being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, will update on this.
could we also add a docs page to /docs/docs/integrations/retrievers |
Hi @baskaryan , will be adding the same |
Hi @baskaryan , hope you are well. I have the following queries. |
@baskaryan , @ccurme @efriis . Any suggestion on these. Would love to hear and work on this to get this merged. |
Hi @Vishnunkumar, is your local
|
Hi @ccurme , thanks will look into it and update. |
Hi @ccurme , Have resolved this, let me know of the next steps. |
Community: "Retrievers: Product Quantization"
Add tests and docs: If you're adding a new integration, please include
Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ - done the same