Adding type index and disabling warns and debug statements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding type_index to procedure symbol and disabling debug statements
landaire
requested changes
Oct 18, 2022
crates/ezpdb/Cargo.toml
Outdated
|
|
||
| [patch.crates-io] | ||
| pdb = { git = "https://github.com/landaire/pdb"} | ||
| [package] |
There was a problem hiding this comment.
This looks like just a whitespace change? LF -> CRLF? Could you remove this from the PR if so?
There was a problem hiding this comment.
Thanks, reverted this.
crates/ezpdb/src/lib.rs
Outdated
| @@ -22,7 +22,7 @@ pub fn parse_pdb<P: AsRef<Path>>( | |||
| base_address: Option<usize>, | |||
| ) -> Result<ParsedPdb, crate::error::Error> { | |||
| let file = File::open(path.as_ref())?; | |||
| debug!("opening PDB"); | |||
| //debug!("opening PDB"); | |||
There was a problem hiding this comment.
I kind of did a side channel here to figure out why this was needed. The debug logic is necessary for debugging my own issues in another tool. If you don't want it, you should configure the logger you're using to filter out this module/crate: https://docs.rs/env_logger/latest/env_logger/struct.Builder.html#method.filter_module
There was a problem hiding this comment.
Reverted the changes here, will use the env_logger fix.
|
@malware-unicorn thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type_index to procedure symbol and disabling warns and debug statements.