Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phrase query may return incorrect results if there's unknown word #2850

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

BubbleCal
Copy link
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Sep 10, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (6016917) to head (d9f4406).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/inverted/builder.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
+ Coverage   78.02%   78.03%   +0.01%     
==========================================
  Files         229      229              
  Lines       70335    70357      +22     
  Branches    70335    70357      +22     
==========================================
+ Hits        54876    54905      +29     
+ Misses      12353    12348       -5     
+ Partials     3106     3104       -2     
Flag Coverage Δ
unittests 78.03% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal marked this pull request as ready for review September 10, 2024 04:32
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have / want a test where all words are unknown?

@BubbleCal BubbleCal merged commit 8c8fb3c into lancedb:main Sep 10, 2024
20 of 22 checks passed
@BubbleCal
Copy link
Contributor Author

Do we have / want a test where all words are unknown?

good point, will add one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants