Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend python bindings for the v2 reader/writer #2800

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

ankitvij-db
Copy link
Contributor

PR extends Python Bindings for V2 Writer/Reader and adds bindings for adding global buffers and adding schema metadata both of which are public functions.

@github-actions github-actions bot added enhancement New feature or request python labels Aug 28, 2024
Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@ankitvij-db ankitvij-db changed the title feat: Extend Python Bindings for V2 Writer/Reader feat: extend python bindings for the v2 reader/writer Aug 28, 2024
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good (pending CI)

@ankitvij-db
Copy link
Contributor Author

ankitvij-db commented Aug 28, 2024

@westonpace How do I re-run a failed CI job? I think I did lint before the commit so not sure why the python linter failed.

@westonpace
Copy link
Contributor

How do I re-run a failed CI job?

CI should automatically run anytime you push a commit. If you need to run a CI job again, without making any changes, the easiest thing to do is usually to rebase main (assuming there is some change). If there are no changes on main, then you can create an empty commit and push that.

I think I did lint before the commit so not sure why the python linter failed.

How did you run the lint? Via IDE? make lint? pre-commit?

I want to make sure our docs are up to date on this. The easiest thing to do is to use pre-commit. We use ruff for linting which is great, but, unfortunately, it seems to change its rules very frequently so its important to match the exact version used in the CI.

@westonpace westonpace merged commit 99563d1 into lancedb:main Aug 29, 2024
11 checks passed
@ankitvij-db
Copy link
Contributor Author

ankitvij-db commented Aug 30, 2024

How did you run the lint?

I did pre-commit

Thanks for fixing and merging this!

@ankitvij-db
Copy link
Contributor Author

@westonpace How does the python wheel gets released?

gagan-bhullar-tech pushed a commit to gagan-bhullar-tech/lance that referenced this pull request Sep 13, 2024
PR extends Python Bindings for V2 Writer/Reader and adds bindings for
adding global buffers and adding schema metadata both of which are
public functions.

---------

Co-authored-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants