-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend python bindings for the v2 reader/writer #2800
Conversation
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good (pending CI)
@westonpace How do I re-run a failed CI job? I think I did lint before the commit so not sure why the python linter failed. |
CI should automatically run anytime you push a commit. If you need to run a CI job again, without making any changes, the easiest thing to do is usually to rebase main (assuming there is some change). If there are no changes on main, then you can create an empty commit and push that.
How did you run the lint? Via IDE? I want to make sure our docs are up to date on this. The easiest thing to do is to use |
I did pre-commit Thanks for fixing and merging this! |
@westonpace How does the python wheel gets released? |
PR extends Python Bindings for V2 Writer/Reader and adds bindings for adding global buffers and adding schema metadata both of which are public functions. --------- Co-authored-by: Weston Pace <weston.pace@gmail.com>
PR extends Python Bindings for V2 Writer/Reader and adds bindings for adding global buffers and adding schema metadata both of which are public functions.