feat: add logging to compaction #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
==========================================
- Coverage 79.28% 79.26% -0.02%
==========================================
Files 227 227
Lines 68269 68293 +24
Branches 68269 68293 +24
==========================================
+ Hits 54126 54135 +9
- Misses 11019 11021 +2
- Partials 3124 3137 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Aug 26, 2024
gagan-bhullar-tech
pushed a commit
to gagan-bhullar-tech/lance
that referenced
this pull request
Sep 13, 2024
Adds basic logging to compaction so that users can see some indication of progress on very long-running compaction jobs. Example output: ``` 2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: Begin compacting 300 rows across 2 fragments [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: Begin compacting 300 rows across 2 fragments [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: Read progress 112/300 [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: Read progress 225/300 [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: Read progress 112/300 [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: Read progress 225/300 [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: file written [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: reserving fragment ids and transposing row ids [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: file written [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: reserving fragment ids and transposing row ids [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 155cbe87-d8fe-44c7-baa2-2072f4353efa: completed [2024-08-26T17:36:31Z INFO lance::dataset::optimize] Compaction task 37e5da68-cd91-4e64-a3e4-3702714332b1: completed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic logging to compaction so that users can see some indication of progress on very long-running compaction jobs. Example output: