feat: stop writing _latest.manifest
#2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
force-pushed
the
feat/eliminate_latest_manifest
branch
from
2de6f38
to
bb3c88b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
- Coverage 79.30% 79.27% -0.03%
==========================================
Files 227 227
Lines 68268 68227 -41
Branches 68268 68227 -41
==========================================
- Hits 54141 54089 -52
- Misses 11006 11026 +20
+ Partials 3121 3112 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chebbyChefNEQ
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: this makes tables written with this and future versions unreadable by Lance v0.8.3 and earlier.
We stopped reading this way back in October of last year (#1365). Continuing to write this can actually cause us to hit per-object mutation rate limits in GCS, so we have some reason to stop doing this now.