-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: split MaterializeIndex stream into batches #2770
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
- Coverage 78.47% 77.94% -0.53%
==========================================
Files 228 229 +1
Lines 69341 70147 +806
Branches 69341 70147 +806
==========================================
+ Hits 54417 54679 +262
- Misses 11859 12389 +530
- Partials 3065 3079 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Wow nice this doesn't just fix my memory issue, it also seems to make my job progress 2.5x faster! |
Unless there's a chance this might break something else, is there any chance you can un-draft this, and save a better solution for the backlog? It's probably not the best solution, but I've been actively using this branch, since it works for brute-force queries. In addition to fixing filter queries, it also seems to fix unfiltered queries on billion-scale datasets. |
35adc71
to
1e293d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks. Can you delete the TODO on line 413?
Fixes #2768
After these changes, we can do the query using <2GB of RAM instead of 33GB! 🚀