Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix two cases in the v2 decoder where the decode order didn't match the scheduling priority #2754

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

westonpace
Copy link
Contributor

This could lead to deadlocks when the io_buffer_size is small (or when page sizes are very large).

Unfortunately, this is not the ideal scheduling algorithm, it uses too much RAM, but it's better to do that than deadlock. Details in #2753

@github-actions github-actions bot added bug Something isn't working python labels Aug 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.23490% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.15%. Comparing base (7284521) to head (a53167a).

Files Patch % Lines
...ust/lance-encoding/src/encodings/logical/struct.rs 82.75% 8 Missing and 2 partials ⚠️
rust/lance-encoding/src/decoder.rs 85.29% 5 Missing ⚠️
rust/lance-encoding/src/encodings/logical/list.rs 87.50% 1 Missing and 3 partials ⚠️
rust/lance-encoding/src/testing.rs 82.35% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
+ Coverage   79.13%   79.15%   +0.02%     
==========================================
  Files         227      227              
  Lines       67398    67441      +43     
  Branches    67398    67441      +43     
==========================================
+ Hits        53338    53386      +48     
+ Misses      10956    10949       -7     
- Partials     3104     3106       +2     
Flag Coverage Δ
unittests 79.15% <85.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 7651740 into lancedb:main Aug 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants