perf: various fixes to improve shuffling performance at high scales #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
force-pushed
the
perf/shuffle-perf
branch
from
eea8d5b
to
856fcf6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
+ Coverage 79.13% 79.21% +0.07%
==========================================
Files 227 227
Lines 67398 67573 +175
Branches 67398 67573 +175
==========================================
+ Hits 53338 53529 +191
+ Misses 10956 10947 -9
+ Partials 3104 3097 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Avoid expensive concatenation by building partitions in-place Parallelize shuffling
westonpace
force-pushed
the
perf/shuffle-perf
branch
from
1d074d2
to
96e6aa2
Compare
BubbleCal
approved these changes
Aug 19, 2024
Co-authored-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix shuffling performance at 1M rows goes from ~2.8 seconds to ~0.8 seconds. At 1B rows we can shuffle in ~6 minutes.