feat: do flat search if too many rows are filtered out #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BubbleCal
commented
Jul 11, 2024
•
BubbleCal
commented
- replace RoaringBitmap with BitVec
- use pool to avoid allocating bitset for each query with prefilter
- fall back to flat search if too many rows filtered out
- prefetch with flat search
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
chebbyChefNEQ
approved these changes
Jul 11, 2024
| let results = self.search_basic(query.clone(), k, params.ef, bitmap, storage)?; | ||
| let keep_count = bitmap.as_ref().map(|b| b.len()).unwrap_or_default() as usize; | ||
| let results = if keep_count < self.len() * 80 / 100 { | ||
| log::info!("too many rows filtered, using flat search"); |
There was a problem hiding this comment.
I think this should be debug
| let keep_count = bitmap.as_ref().map(|b| b.len()).unwrap_or_default() as usize; | ||
| let results = if keep_count < self.len() * 80 / 100 { | ||
| log::info!("too many rows filtered, using flat search"); | ||
| let bitmap = bitmap.unwrap(); |
There was a problem hiding this comment.
Nit: handle error or use expect
| let dist_calc = storage.dist_calculator(query); | ||
| let mut heap = BinaryHeap::<Reverse<OrderedNode>>::with_capacity(k); | ||
| for node_id in node_ids { | ||
| let dist = dist_calc.distance(node_id).into(); |
There was a problem hiding this comment.
Nit: calculate distance and sort in two stages might be faster?
There was a problem hiding this comment.
it will if there are not many rows, we can figure out a good threshold here. will do more benchmark here to get it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
- Coverage 80.11% 80.05% -0.06%
==========================================
Files 211 211
Lines 61085 61155 +70
Branches 61085 61155 +70
==========================================
+ Hits 48937 48959 +22
- Misses 9215 9256 +41
- Partials 2933 2940 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
pushed a commit
that referenced
this pull request
Jul 11, 2024
- replace RoaringBitmap with BitVec - use pool to avoid allocating bitset for each query with prefilter - fall back to flat search if too many rows filtered out - prefetch with flat search --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.