feat: integrate bitmap index into top-level lance APIs #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Jul 8, 2024
| @@ -1103,7 +1103,7 @@ def cleanup_old_versions( | |||
| def create_scalar_index( | |||
| self, | |||
| column: str, | |||
| index_type: Literal["BTREE"], | |||
| index_type: Union[Literal["BTREE"], Literal["BITMAP"]], | |||
There was a problem hiding this comment.
Should we have a default index type to BTREE, like what MySQL / Postgres do?
There was a problem hiding this comment.
We should automatically pick the index type based on cardinality by default. I'm hoping to do this in a future PR (or maybe @raunaks13 )
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 80.01% 80.08% +0.06%
==========================================
Files 210 211 +1
Lines 60323 61038 +715
Branches 60323 61038 +715
==========================================
+ Hits 48270 48881 +611
- Misses 9182 9226 +44
- Partials 2871 2931 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a minor synchronization perf issue in the prefilter search path