fix: avoid multiple threads loading same index partition #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
==========================================
- Coverage 80.00% 79.99% -0.02%
==========================================
Files 209 209
Lines 59847 59864 +17
Branches 59847 59864 +17
==========================================
+ Hits 47880 47887 +7
- Misses 9143 9148 +5
- Partials 2824 2829 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
reviewed
Jul 4, 2024
| @@ -65,3 +70,53 @@ pub async fn maybe_sample_training_data( | |||
| })?; | |||
| Ok(array.as_fixed_size_list().clone()) | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| pub struct PartitionLoadLock { | |||
There was a problem hiding this comment.
Is this pub(crate). Just wanted to make sure this is not public API
There was a problem hiding this comment.
this is in a private module, so it won't be part of public API
rust/lance/src/index/vector/utils.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| pub struct PartitionLoadLock { | ||
| partition_locks: RwLock<HashMap<String, Arc<Mutex<()>>>>, |
There was a problem hiding this comment.
if we make this vec![Arc<Mutex()] with pre-allocated mutex, we dont need RWlock?
albertlockett
changed the title
albertlockett
force-pushed
the
index-load-lock
branch
from
13de1b2
to
1b74d8c
Compare
eddyxu
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds locks for loading of index partitions. This voids multiple threads querying concurrently from both allocating memory to load the partition, which can cause memory issues during application startup.